Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 回退生成 nodeId 时对 extra 字段的格式化 #2546

Merged
merged 4 commits into from
Feb 7, 2024
Merged

fix: 回退生成 nodeId 时对 extra 字段的格式化 #2546

merged 4 commits into from
Feb 7, 2024

Conversation

wjgogogo
Copy link
Contributor

@wjgogogo wjgogogo commented Feb 6, 2024

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Feb 7, 2024 3:36am

@github-actions github-actions bot added next 2.0-next 版本的问题 pr(fix) bug fix labels Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

你好, @wjgogogo CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @wjgogogo CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

Size Change: -13 B (0%)

Total Size: 316 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 221 kB -13 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/index.min.js 68.5 kB
./packages/s2-react/dist/style.min.css 4.01 kB
./packages/s2-vue/dist/index.min.js 20.2 kB
./packages/s2-vue/dist/style.min.css 1.98 kB

compressed-size-action

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Feb 7, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecdc9c8) 75.77% compared to head (f4bf484) 78.38%.
Report is 242 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2546      +/-   ##
==========================================
+ Coverage   75.77%   78.38%   +2.61%     
==========================================
  Files         257      275      +18     
  Lines       11994    12502     +508     
  Branches     2464     2559      +95     
==========================================
+ Hits         9088     9800     +712     
+ Misses       1398     1144     -254     
- Partials     1508     1558      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit 7d1cf9a into next Feb 7, 2024
10 of 11 checks passed
@wjgogogo wjgogogo deleted the fix-custom-value-order branch February 7, 2024 05:47
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.0.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijinke666 lijinke666 lijinke666 approved these changes

@wuhaiyang wuhaiyang Awaiting requested review from wuhaiyang

Assignees

@wjgogogo wjgogogo

Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjgogogo @lijinke666